Skip to content

Grouper tweaks. #10362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025
Merged

Grouper tweaks. #10362

merged 2 commits into from
May 30, 2025

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented May 28, 2025

  1. Remove private fields from UniqueGrouper.__init__, this was an oversight
  2. Raise error if trying to group by a Grouper

Closes #10356 by raising better error messages.

@dcherian dcherian force-pushed the grouper-tweaks branch 2 times, most recently from 9c844e0 to 0a66a83 Compare May 28, 2025 15:06
@dcherian dcherian added the plan to merge Final call for comments label May 28, 2025
1. Remove private fields from UniqueGrouper.__init__
2. Raise error if trying to group by a Grouper

Closes pydata#10356
@dcherian dcherian merged commit 42836f3 into pydata:main May 30, 2025
32 checks passed
dcherian added a commit to dcherian/xarray that referenced this pull request May 30, 2025
* main:
  Fix performance regression in interp from pydata#9881 (pydata#10370)
  html repr: improve style for dropdown sections (pydata#10354)
  Grouper tweaks. (pydata#10362)
  Docs: Add links to getting help mermaid diagram (pydata#10324)
  Enforce ruff/flynt rules (FLY) (pydata#10375)
  Add missing AbstractWritableDataStore base methods and arguments (pydata#10343)
  Improve html repr in dark mode (Jupyterlab + Xarray docs) (pydata#10353)
  Pin Mypy to 1.15 (pydata#10378)
  use numpy dtype exposed by zarr array instead of metadata.data_type (pydata#10348)
  Fix doc typo for caption "Interoperability" (pydata#10374)
  Implement cftime vectorization as discussed in PR pydata#8322 (pydata#8324)
  Enforce ruff/flake8-pyi rules (PYI) (pydata#10359)
  Apply assorted ruff/Pylint rules (PL) / Enforce PLE rules (pydata#10366)
  (fix): pandas extension array repr for int64[pyarrow] (pydata#10317)
  Enforce ruff/flake8-implicit-str-concat rules (ISC) (pydata#10368)
  Enforce ruff/refurb rules (FURB) (pydata#10367)
  Ignore ruff/Pyflakes rule F401 more precisely (pydata#10369)
  Apply assorted ruff/flake8-simplify rules (SIM) (pydata#10364)
  Apply assorted ruff/flake8-pytest-style rules (PT) (pydata#10363)
  Fix "a array" misspelling (pydata#10365)
@dcherian dcherian deleted the grouper-tweaks branch June 4, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xarray 2025.4.0: issues with grouping using external arrays
2 participants