Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support inline_array kwarg in open_zarr #8095

Open
dcherian opened this issue Aug 21, 2023 · 2 comments
Open

Support inline_array kwarg in open_zarr #8095

dcherian opened this issue Aug 21, 2023 · 2 comments
Labels
bug topic-backends topic-zarr Related to zarr storage library

Comments

@dcherian
Copy link
Contributor

dcherian commented Aug 21, 2023

cc @TomNicholas

What happened?

There is no way to specify inline_array in open_zarr. Instead we have to use open_dataset.

Minimal Complete Verifiable Example

import xarray as xr

xr.Dataset({"a": xr.DataArray([1.0])}).to_zarr("temp.zarr")
xr.open_zarr('temp.zarr', inline_array=True)
ValueError: argument inline_array cannot be passed both as a keyword argument and within the from_array_kwargs dictionary
xr.open_zarr('temp.zarr', from_array_kwargs=dict(inline_array=True))
ValueError: argument inline_array cannot be passed both as a keyword argument and within the from_array_kwargs dictionary
@dcherian dcherian added bug needs triage Issue that has not been reviewed by xarray team member topic-backends topic-zarr Related to zarr storage library and removed needs triage Issue that has not been reviewed by xarray team member labels Aug 21, 2023
@krokosik
Copy link
Contributor

There are plans to deprecate the open_zarr method in favor of using open_dataset and open_dataarray only. See #7495

@krokosik
Copy link
Contributor

Maybe we should instead add an error that tells the user to use open_dataset instead?

@krokosik krokosik mentioned this issue Sep 21, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug topic-backends topic-zarr Related to zarr storage library
Projects
None yet
Development

No branches or pull requests

2 participants