Skip to content

backwards incompatible changes in reductions #6408

Closed
@dcherian

Description

@dcherian

What is your issue?

I merged #5950 but forgot that it included some backward-incompatible changes (Sorry! this came up in #6403 thanks to @mathause for spotting.)

  1. Arguments like keep_attrs, axis are now keyword-only.
  2. Some reductions had the 3rd position arg as keep_attrs and in other cases it was axis.

These have been standardized now, and only dim is accepted without kwarg-name.

@pydata/xarray Should we add a deprecation cycle (#5531)? Point (2) above will make it a little messy.

At the very least we should add a deprecation notice before releasing.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions