You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When writing cftime_range I used dates from a proleptic Gregorian calendar when the calendar type was specified as 'standard'. While this is consistent with Python's built-in datetime.datetime(which uses a proleptic Gregorian calendar), this differs from the behavior in cftime.num2date and ultimately the CF conventions, which state that 'standard' should refer to the true Gregorian calendar. My inclination is that considering "cf" is in the name of cftime_range, we should adhere to those conventions as closely as possible (and hence the way I initially coded things was a mistake).
Do others agree that we should fix this? If we were to make this change, would it be appropriate to consider it a bug and simply make the breaking change immediately, or might we need a deprecation cycle?
The text was updated successfully, but these errors were encountered:
Code Sample, a copy-pastable example if possible
Problem description
When writing
cftime_range
I used dates from a proleptic Gregorian calendar when the calendar type was specified as'standard'
. While this is consistent with Python's built-indatetime.datetime
(which uses a proleptic Gregorian calendar), this differs from the behavior incftime.num2date
and ultimately the CF conventions, which state that'standard'
should refer to the true Gregorian calendar. My inclination is that considering "cf" is in the name ofcftime_range
, we should adhere to those conventions as closely as possible (and hence the way I initially coded things was a mistake).Expected Output
Do others agree that we should fix this? If we were to make this change, would it be appropriate to consider it a bug and simply make the breaking change immediately, or might we need a deprecation cycle?
The text was updated successfully, but these errors were encountered: