Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Things to complete before releasing xarray v0.9.0 #1167

Closed
4 tasks done
shoyer opened this issue Dec 16, 2016 · 18 comments
Closed
4 tasks done

Things to complete before releasing xarray v0.9.0 #1167

shoyer opened this issue Dec 16, 2016 · 18 comments

Comments

@shoyer
Copy link
Member

shoyer commented Dec 16, 2016

@pydata/xarray anything else essential?

@max-sixty
Copy link
Collaborator

max-sixty commented Dec 16, 2016

Are we pushing #964? This would be awesome to start building on, although important to get right given it'll be a platform

@shoyer
Copy link
Member Author

shoyer commented Dec 22, 2016

I also really want to merge #964 (the "apply" function) but the current API is a little too confusing. We could merge it without exposing it as public API for now and/or start building simplified versions (e.g., with an optional dim argument instead of signature).

I agree that it should be a top priority but I don't want to let it hold up 0.9 any longer, so I think we should release without it. apply does not change any APIs in a breaking way so we can even both put it in a minor release if desried (though obviously it is a big feature).

@jhamman
Copy link
Member

jhamman commented Dec 23, 2016

I have two smaller features I'd like to get in:

These are both pretty close and could be wrapped up in a day or so.

@shoyer
Copy link
Member Author

shoyer commented Dec 27, 2016

What's our status here? I'd like to get the release (maybe a release candidate) out this week if possible.

It would be great if someone else could take a look at #1166 and #1179.

@shoyer
Copy link
Member Author

shoyer commented Jan 11, 2017

There is never an ideal time to make a release cut, but this has been dragging on for too long. I just sent out an email announcing a release candidate for v0.9.0:
https://groups.google.com/forum/#!topic/xarray/Yc6A45zXmwM

Unlimited dimensions will have to wait to the v0.9.1 release, but that release can follow pretty shortly given that the changes should be mostly backwards compatible.

@ghisvail
Copy link
Contributor

@shoyer Do you plan to push a release tarball for 0.9.0rc1 on PyPI? I'd prefer to use this version over 0.8.2 as the basis for the initial Debian packaging. I tested both and found 0.9.0rc1 to lead to less errors with the test suite than 0.8.2. I could also wait for 0.9.0 final if its release is planned soon.

@shoyer
Copy link
Member Author

shoyer commented Jan 15, 2017

@ghisvail Oops, I forgot to upload the source distribution to pypi (now fixed).

The final release should be some time this week, up to you if you want to wait.

@ghisvail
Copy link
Contributor

The final release should be some time this week, up to you if you want to wait.

Thanks @shoyer, I used the rc to try out the packaging and give you some initial feedback. See #1208 and #1209.

@fmaussion
Copy link
Member

fmaussion commented Jan 22, 2017

If I wrap up this thread, I see we are missing:

@shoyer
Copy link
Member Author

shoyer commented Jan 24, 2017

With the merge of #1222, I plan to issue the new release tonight or tomorrow morning (pending a successful doc build and a final check-over).

@fmaussion
Copy link
Member

It is picky but it might be worth to pin mpl to v2 for nicer plots in the docs ;-) Am I allowed to try it out?

@shoyer
Copy link
Member Author

shoyer commented Jan 24, 2017 via email

@rabernat
Copy link
Contributor

rabernat commented Jan 24, 2017

Not that this matters greatly to xarray, but I am happy to report that the latest master causes no problems with xmitgcm, which, because of the custom DataStore, is a somewhat obscure edge case. Full speed ahead with the release!

@shoyer
Copy link
Member Author

shoyer commented Jan 24, 2017

@rabernat the DataStore refactor will happen sometime soon I hope, but I will definitely coordinate with you!

@jhamman
Copy link
Member

jhamman commented Jan 24, 2017

@shoyer - glad this is coming together. Let me know if you'd like any help with the release steps.

@fmaussion
Copy link
Member

@shoyer I've tested mpl on the fix-docs branch and they seem to build properly (see the dashboard), but for some reason xarray's webpage is unreachable right now so I can't see how it looks like. It's getting late here in central europe so if you want to make the release later today go ahead, MPL2 can wait.

@shoyer
Copy link
Member Author

shoyer commented Jan 24, 2017 via email

@pwolfram
Copy link
Contributor

I think we can close this because 0.9.0 has been released.

@jhamman jhamman closed this as completed Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants