Skip to content

Commit

Permalink
Fix mypy type checking tests failure in ds.merge (#3690)
Browse files Browse the repository at this point in the history
* Added DataArray as valid type input to ds.merge method

* Fix import error by specifying type as string
  • Loading branch information
TomNicholas authored and dcherian committed Jan 13, 2020
1 parent 59d3ba5 commit 8a650a1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion xarray/core/dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -3550,7 +3550,7 @@ def update(self, other: "CoercibleMapping", inplace: bool = None) -> "Dataset":

def merge(
self,
other: "CoercibleMapping",
other: Union["CoercibleMapping", "DataArray"],
inplace: bool = None,
overwrite_vars: Union[Hashable, Iterable[Hashable]] = frozenset(),
compat: str = "no_conflicts",
Expand Down

0 comments on commit 8a650a1

Please sign in to comment.