Remove code used to support h5py<2.10.0

hmaarrfk · hmaarrfk · commit 8611dbe0a1e6 · 2022-11-29T14:32:19.000-05:00
It seems that the relevant issue was fixed in 2.10.0 h5py/h5py@466181b I'm not sure how far back you want to fix things. I'm hoping to test this on the CI. I found this since I've been auditing slowdowns in our codebase, which has caused me to review much of the reading pipeline.
diff --git a/xarray/backends/h5netcdf_.py b/xarray/backends/h5netcdf_.py
@@ -46,9 +46,6 @@ def __getitem__(self, key):
         )
 
     def _getitem(self, key):
-        # h5py requires using lists for fancy indexing:
-        # https://github.com/h5py/h5py/issues/992
-        key = tuple(list(k) if isinstance(k, np.ndarray) else k for k in key)
         with self.datastore.lock:
             array = self.get_array(needs_lock=False)
             return array[key]

Original file line number	Diff line number	Diff line change
`@@ -46,9 +46,6 @@ def __getitem__(self, key):`
`46`	`46`	`)`
`47`	`47`
`48`	`48`	`def _getitem(self, key):`
`49`		`- # h5py requires using lists for fancy indexing:`
`50`		`- # https://github.com/h5py/h5py/issues/992`
`51`		`- key = tuple(list(k) if isinstance(k, np.ndarray) else k for k in key)`
`52`	`49`	`with self.datastore.lock:`
`53`	`50`	`array = self.get_array(needs_lock=False)`
`54`	`51`	`return array[key]`