Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.13 plan #1109

Closed
8 tasks done
choldgraf opened this issue Jan 8, 2023 · 11 comments
Closed
8 tasks done

Release 0.13 plan #1109

choldgraf opened this issue Jan 8, 2023 · 11 comments
Milestone

Comments

@choldgraf
Copy link
Collaborator

choldgraf commented Jan 8, 2023

It has been a couple months since our last release and we have made many improvements since then. There are still a few things we should finish before another release, but I wonder how folks feel about making a release relatively soon.

Checklist

Next: incorporate the next a11y work etc in the following release after.

@choldgraf choldgraf changed the title Release 0.13 Release 0.13 soon? Jan 8, 2023
@choldgraf choldgraf changed the title Release 0.13 soon? Release 0.13 plan Jan 11, 2023
@choldgraf choldgraf added this to the 0.13 milestone Jan 11, 2023
@choldgraf choldgraf pinned this issue Jan 11, 2023
@choldgraf
Copy link
Collaborator Author

choldgraf commented Jan 26, 2023

Hey all - if I don't hear objections I'll make a release candidate the next time I have a moment. I know there are some outstanding PRs, but this will help others test out the new version and we might surface some new bugs as well before a full release.

Edit: actually I'm going to hold off until we figure out the HTML logo issue because I think that will confuse a lot of people

@choldgraf
Copy link
Collaborator Author

OK release candidate is out!

@choldgraf
Copy link
Collaborator Author

Any objections to making a full release in the next day or two?

@choldgraf
Copy link
Collaborator Author

New release candidate is out. See it here: https://github.com/pydata/pydata-sphinx-theme/releases/tag/v0.13.0rc3

I've also added a changelog that we can re-use for the final release.

@jayaddison
Copy link
Contributor

Can you recommended an email address / other place to send security-related pydata questions @choldgraf? (for this release, and/or in general?)

@choldgraf
Copy link
Collaborator Author

choldgraf commented Feb 20, 2023

Hello @jayaddison - we don't currently have a contact e-mail, I opened this issue to track that:

This theme has no dedicated resources, so we cannot make any promises about responding to security issues or follow-ups. However we are happy to review PRs that implement fixes.

@jayaddison
Copy link
Contributor

Thanks @choldgraf, understood - it's not an important concern in this case - it seems unlikely and theoretical, but I became aware of a possible issue while working on something unrelated to pydata. I'll open a pull request soon (it should be a small fix).

@jayaddison
Copy link
Contributor

Opened #1204 - it may be a waste of time, to be completely honest (while writing it up I felt that it is so unlikely to be an issue as to perhaps not worth mentioning at all), but hopefully making it aware and then allowing you to make that choice is reasonable in this case.

@choldgraf
Copy link
Collaborator Author

OK I think that we are pretty much ready for a release...cut a new RC with the latest changes to make sure that the translations were correctly in there, and indeed I did see the .mo files in our .whl, so I think we can go whenever. If anybody disagrees please ping here, otherwise let's release tomorrow?

@12rambau
Copy link
Collaborator

I just made the v0.13 release, people can now run our theme with Sphinx v6

@12rambau 12rambau unpinned this issue Feb 28, 2023
@choldgraf
Copy link
Collaborator Author

Many thanks @12rambau for making the release 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants