BUG: Yahoo actions adjustment is incorrect #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Yahoo actions dividend adjustment
bashtage
force-pushed
the
xfail-yahoo-actions
branch
from
7fa2213 to
02f1fdf
Compare
|
This looks correct now for AAPL, but incorrect for BHP (which is what I based the code / tests on). Yahoo must be treating the two exchanges differently. |
|
Just to make sure there are no regressions, I'll change the test to AAPL. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Yahoo actions dividend adjustment
git diff upstream/master -u -- "*.py" | flake8 --diff