Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using enum dispatch #41

Merged
merged 2 commits into from
May 2, 2022
Merged

using enum dispatch #41

merged 2 commits into from
May 2, 2022

Conversation

samuelcolvin
Copy link
Member

Using enum dispatch instead of box.

Some boxes can't be removed.

Seem to give a ~10% speedup over main.

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #41 (07ad2f0) into main (6ebcfda) will decrease coverage by 0.13%.
The diff coverage is 90.47%.

@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
- Coverage   86.72%   86.59%   -0.14%     
==========================================
  Files          28       28              
  Lines        2238     2313      +75     
==========================================
+ Hits         1941     2003      +62     
- Misses        297      310      +13     
Impacted Files Coverage Δ
src/lib.rs 100.00% <ø> (ø)
src/validators/any.rs 73.33% <40.00%> (-18.34%) ⬇️
src/validators/function.rs 79.04% <58.06%> (-4.08%) ⬇️
src/validators/model.rs 89.20% <62.50%> (-0.46%) ⬇️
src/validators/dict.rs 70.88% <87.50%> (+0.75%) ⬆️
src/validators/bool.rs 100.00% <100.00%> (ø)
src/validators/float.rs 98.34% <100.00%> (+0.14%) ⬆️
src/validators/int.rs 98.34% <100.00%> (+0.14%) ⬆️
src/validators/list.rs 76.92% <100.00%> (+0.29%) ⬆️
src/validators/literal.rs 95.76% <100.00%> (+0.36%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ebcfda...07ad2f0. Read the comment docs.

@samuelcolvin samuelcolvin merged commit bc2c0ec into main May 2, 2022
@samuelcolvin samuelcolvin deleted the enum_dispatch branch May 2, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant