Skip to content

Commit 51ac71a

Browse files
Attempt fix - release build failed, need to install typing-extensions from main until a version after v4.12.1 (#1313)
1 parent 37ad925 commit 51ac71a

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

.github/workflows/ci.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,6 @@ jobs:
9090
python-version: ${{ matrix.python-version }}
9191

9292
- run: pip install -r tests/requirements.txt
93-
# TODO: remove this after the the next release of typing-extensions (v4.12.3 or v.4.13.0)
94-
- run: pip uninstall -y typing-extensions
95-
- run: pip install -U git+https://github.com/python/typing_extensions@main
9693

9794
- run: pip install -e .
9895
env:
@@ -662,10 +659,8 @@ jobs:
662659
fi
663660
run: |
664661
set -x
665-
# typing-extensions isn't automatically installed because of `--no-index --no-deps`
666662
python3 -m venv venv
667663
source venv/bin/activate
668-
python3 -m pip install -U pip typing-extensions
669664
python3 -m pip install -r tests/requirements.txt
670665
python3 -m pip install pydantic-core --no-index --no-deps --find-links dist --force-reinstall
671666
python3 -m pytest --ignore=tests/test_docstrings.py
@@ -696,7 +691,6 @@ jobs:
696691
merge-multiple: true
697692
path: dist
698693

699-
- run: pip install typing-extensions
700694
- run: pip install -r tests/requirements.txt
701695
- run: pip install pydantic-core --no-index --no-deps --find-links dist --force-reinstall
702696
- run: pytest --ignore=tests/test_docstrings.py

tests/requirements.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,3 +21,5 @@ pytest-timeout==2.3.1
2121
numpy==1.26.2; python_version >= "3.9" and python_version < "3.13" and implementation_name == "cpython" and platform_machine == 'x86_64'
2222
exceptiongroup==1.1; python_version < "3.11"
2323
tzdata==2024.1
24+
# TODO: remove manual override for typing_extensions once a version newer than 4.12.1 is released
25+
git+https://github.com/python/typing_extensions@main

0 commit comments

Comments
 (0)