fmt

Author: adriangb

datafusion/datasource-parquet/src/row_filter.rs

@@ -120,7 +120,8 @@ impl DatafusionArrowPredicate {
         time: metrics::Time,
     ) -> Result<Self> {
         let projected_schema = Arc::clone(&candidate.filter_schema);
-        let physical_expr = transform_physical_expr_with_schema(candidate.expr, &projected_schema)?;
+        let physical_expr =
+            transform_physical_expr_with_schema(candidate.expr, &projected_schema)?;
 
         Ok(Self {
             physical_expr,

datafusion/physical-expr-common/src/physical_expr.rs

@@ -337,10 +337,7 @@ pub trait PhysicalExpr: Send + Sync + Display + Debug + DynEq + DynHash {
     /// Adapt this [`PhysicalExpr`] to a new schema.
     /// For example, `Column("b", 1)` can be adapted to `Column("b", 0)`
     /// given the schema `Schema::new(vec![("b", DataType::Int32)])`.
-    fn with_schema(
-        &self,
-        _schema: &Schema,
-    ) -> Result<Option<Arc<dyn PhysicalExpr>>> {
+    fn with_schema(&self, _schema: &Schema) -> Result<Option<Arc<dyn PhysicalExpr>>> {
         // By default, we return the same expression.
         // This is a safe default behavior.
         Ok(None)
@@ -551,4 +548,4 @@ pub fn transform_physical_expr_with_schema(
         }
     })
     .data()
-}
+}

datafusion/physical-expr/src/expressions/column.rs

@@ -142,10 +142,7 @@ impl PhysicalExpr for Column {
         write!(f, "{}", self.name)
     }
 
-    fn with_schema(
-            &self,
-            schema: &Schema,
-        ) -> Result<Option<Arc<dyn PhysicalExpr>>> {
+    fn with_schema(&self, schema: &Schema) -> Result<Option<Arc<dyn PhysicalExpr>>> {
         // Find our index in the new schema
         let new_index = schema.index_of(&self.name)?;
         // If the index is the same return None to indicate no change

datafusion/physical-expr/src/expressions/dynamic_filters.rs

@@ -334,11 +334,13 @@ mod test {
         // Each ParquetExec calls `with_new_children` on the DynamicFilterPhysicalExpr
         // and remaps the children to the file schema.
         let filter = Arc::clone(&dynamic_filter);
-        let dynamic_filter_1 = transform_physical_expr_with_schema(filter, &filter_schema_1).unwrap();
+        let dynamic_filter_1 =
+            transform_physical_expr_with_schema(filter, &filter_schema_1).unwrap();
         let snap = dynamic_filter_1.snapshot().unwrap().unwrap();
         insta::assert_snapshot!(format!("{snap:?}"), @r#"BinaryExpr { left: Column { name: "a", index: 0 }, op: Eq, right: Literal { value: Int32(42) }, fail_on_overflow: false }"#);
         let filter = Arc::clone(&dynamic_filter);
-        let dynamic_filter_2 = transform_physical_expr_with_schema(filter, &filter_schema_2).unwrap();
+        let dynamic_filter_2 =
+            transform_physical_expr_with_schema(filter, &filter_schema_2).unwrap();
         let snap = dynamic_filter_2.snapshot().unwrap().unwrap();
         insta::assert_snapshot!(format!("{snap:?}"), @r#"BinaryExpr { left: Column { name: "a", index: 1 }, op: Eq, right: Literal { value: Int32(42) }, fail_on_overflow: false }"#);
         // Both filters allow evaluating the same expression