fix: small fix for dev docker #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adehad
reviewed
Dec 27, 2023
studioj
force-pushed
the
fix/dev-docker-needs-some-package
branch
from
79bf482 to
7b39544
Compare
|
I think the key is to change the Ran a test now where I built the devcontainer from that branch and it seems to have worked as expected: It successfully used the jammy version and installed the project |
|
Regarding the test failing, I think it is now how when deleting a project the project does not get permanently deleted, but exists in a 'trash', so it is still 'found' by some endpoints but not others. A bit weird I thought I fixed with the right new parameter, but it seems not? |
adehad
reviewed
Dec 27, 2023
Co-authored-by: Adel Haddad <26027314+adehad@users.noreply.github.com>
studioj
commented
Dec 27, 2023
adehad
approved these changes
Dec 27, 2023
was intending to do a small one but then i saw CI failing :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bumping to focal (hirsute is not maintained anymore)
and libkrb5 was needed otherwise there were weird install errors after running tox