Skip to content

Add client hello callback related functions #13634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add client hello callback related functions #13634

wants to merge 1 commit into from
+39 −0

Conversation

schwabe
Copy link

@schwabe schwabe commented Oct 10, 2025

This exposes the OpenSSL functions SSL_CTX_set_client_hello_cb, SSL_client_hello_get0_ext and SSL_client_hello_get1_extensions_present.

These are required to implement to the client hello callback functionality in pyOpenSSL.

@schwabe schwabe mentioned this pull request Oct 10, 2025
Open
Tarnum-tst
Tarnum-tst suggested changes Oct 10, 2025
View reviewed changes
Copy link

@Tarnum-tst Tarnum-tst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

void SSL_CTX_set_client_hello_cb(
    SSL_CTX *,
    int (*)(SSL *, int *, void *),
    void *);
int SSL_client_hello_get1_extensions_present(
    SSL *, int **,
    size_t *);
int SSL_client_hello_get0_ext(
    SSL *, unsigned int,
    const unsigned char **,
    size_t *);

@schwabe schwabe force-pushed the add_client_hello_callback branch from de59175 to 8e49ebb Compare October 10, 2025 13:04
@schwabe
Copy link
Author

schwabe commented Oct 10, 2025

@Tarnum-tst I assume that is about not having names for the parameter? If yes I fixed that. If there was something else wrong, please point it out to me.

@schwabe
Add client hello callback related functions
346e8af 
This exposes the OpenSSL functions SSL_CTX_set_client_hello_cb,
SSL_client_hello_get0_ext and SSL_client_hello_get1_extensions_present.

These are required to implement to the client hello callback
functionality in pyOpenSSL.

Signed-off-by: Arne Schwabe <arne@rfc2549.org>
@schwabe schwabe force-pushed the add_client_hello_callback branch from 8e49ebb to 346e8af Compare October 10, 2025 13:20
alex
alex approved these changes Oct 11, 2025
View reviewed changes
Copy link
Member

@alex alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending confirmation on the pyopenssl side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alex alex alex approved these changes

+1 more reviewer

@Tarnum-tst Tarnum-tst Tarnum-tst requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@schwabe @alex @Tarnum-tst