Conversation
|
Not following closely, do we know why we have to skip for builds of windows above that value? |
Sorry I don't, at all. I hope someone else will pick this up. I stumbled over this while working on #5796 (comment) When I saw the Bottom line: This PR doesn't fix anything, but
|
tests/test_iostream.py
Outdated
|
|
||
| from pybind11_tests import iostream as m | ||
|
|
||
| if sys.platform == "win32": |
There was a problem hiding this comment.
| if sys.platform == "win32": | |
| if sys.platform.startswith("win32"): |
It's canonical to use startswith when checking sys.platform, though it's often not required.
There was a problem hiding this comment.
Looking at this with a fresh eye: For a moment I forgot that we have env.WIN. Changed to use that: commit 8b79a85
tests/test_iostream.py
Outdated
| if wv_build >= skip_if_ge: | ||
| pytest.skip( | ||
| f"Windows build {wv_build} >= {skip_if_ge}:" | ||
| " Skipping iostream capture (redirection regression under investigation)", |
There was a problem hiding this comment.
| " Skipping iostream capture (redirection regression under investigation)", | |
| " Skipping iostream capture (redirection regression needs investigation)", |
|
Thanks @henryiii! |
2 participants
Description
test_iostream.pySuggested changelog entry: