Skip to content

tests: skip some flaky gil tests on nogil #5699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025

Conversation

henryiii
Copy link
Collaborator

Description

Skipping test listed in #5674. Would prefer a fix, but these are GIL tests running in free-threaded Python, so skipping is okay. I've not been able to reproduce the flakes locally.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First time I see the fine-grained override feature, nice!

@henryiii
Copy link
Collaborator Author

I also used in the the test_pickling test for 3.14.0b1/2, so you have seen it at least once before. ;)

@henryiii henryiii merged commit 57e27c1 into pybind:master May 27, 2025
74 checks passed
@henryiii henryiii deleted the henryiii/tests/skipgil branch May 27, 2025 15:22
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label May 27, 2025
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants