Skip to content

chore: rename macro PYBIND11_SUBINTERPRETER_SUPPORT -> PYBIND11_HAS_SUBINTERPRETER_SUPPORT to meet naming convention #5682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

chore: rename macro PYBIND11_SUBINTERPRETER_SUPPORT -> PYBIND11_HAS_SUBINTERPRETER_SUPPORT to meet naming convention #5682

merged 1 commit into from
May 22, 2025

Conversation

XuehaiPan
Copy link
Contributor

Description

Suggested changelog entry:

  • Rename macro PYBIND11_SUBINTERPRETER_SUPPORT -> PYBIND11_HAS_SUBINTERPRETER_SUPPORT to meet naming convention.

@XuehaiPan
chore: rename macro PYBIND11_SUBINTERPRETER_SUPPORT -> `PYBIND11_HA…
257b481 
…S_SUBINTERPRETER_SUPPORT` to meet naming convention
rwgk
rwgk approved these changes May 22, 2025
View reviewed changes
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! (I feel a bit silly about not noticing before, because I just worked on #5647).

I believe it's not yet too late to make this change.

@b-pass @henryiii WDYT?

@henryiii
Copy link
Collaborator

I think this is a fine change to make since we haven't released final yet.

@rwgk rwgk merged commit 98bd78f into pybind:master May 22, 2025
74 checks passed
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label May 22, 2025
@XuehaiPan XuehaiPan deleted the rename-macro branch May 23, 2025 07:53
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label May 29, 2025
@BrewTestBot BrewTestBot mentioned this pull request Jul 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwgk rwgk rwgk approved these changes

@henryiii henryiii henryiii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XuehaiPan @henryiii @rwgk