Skip to content

fix: icc needs cast, upgrade 20.04 runners to 22.04 (ICC, NVHPC) #5621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025

Conversation

dyollb
Copy link
Contributor

@dyollb dyollb commented Apr 16, 2025

Description

Upgrade the deprecated 20.04 runners to 22.04 (ICC, NVHPC)

  • the LTS runner was removed on April 15

Suggested changelog entry:

* Fix a missing time cast causing a compile error for newer ICC

@dyollb dyollb requested a review from henryiii as a code owner April 16, 2025 08:57
@henryiii henryiii merged commit 5c49858 into pybind:master Apr 16, 2025
65 checks passed
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Apr 16, 2025
b-pass pushed a commit to b-pass/pybind11 that referenced this pull request May 9, 2025
* Upgrade the deprecated 20.04 runners to 22.04 (ICC, NVHPC)

* fix ICC compile error

---------

Co-authored-by: Bryn Lloyd <12702862+dyollb@users.noreply.github.com>
@henryiii henryiii changed the title Upgrade the deprecated 20.04 runners to 22.04 (ICC, NVHPC) fix: icc needs cast, upgrade 20.04 runners to 22.04 (ICC, NVHPC) May 17, 2025
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants