Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[smart_holder] Remove test_classh_mock.cpp,py #5338

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Aug 26, 2024

Description

This test became obsolete when PR #5257 was merged.

It was not removed with PR #5257 only to minimize the diff.

It is removed now to minimize the diff under the PR merging the smart_holder branch into the master branch.

Suggested changelog entry:

@rwgk rwgk marked this pull request as ready for review August 26, 2024 18:55
@rwgk rwgk requested a review from henryiii as a code owner August 26, 2024 18:55
@rwgk rwgk merged commit f99ffd7 into pybind:smart_holder Aug 26, 2024
78 of 79 checks passed
@rwgk rwgk deleted the remove_test_classh_mock branch August 26, 2024 18:56
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Aug 26, 2024
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant