feat: require CMake 3.15+ #5304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/feat/cmake315
branch
from
a7ca742
to
3d4179b
Compare
henryiii
commented
Aug 13, 2024
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
rwgk
approved these changes
Aug 14, 2024
| if(TARGET pybind11::pybind11) | ||
| return() | ||
| endif() | ||
| include_guard(GLOBAL) |
There was a problem hiding this comment.
This does not work well in config mode if one does find_package multiple times...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove support for ancient versions of CMake.
Suggested changelog entry: