Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump cmake to 3.29 #5075

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

henryiii
Copy link
Collaborator

Signed-off-by: Henry Schreiner henryschreineriii@gmail.com

Description

Suggested changelog entry:

Bump max cmake to 3.29

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing the labeler? :-)

@henryiii
Copy link
Collaborator Author

Crossed my mind, yes. :) Going to work on the release first, though.

@henryiii henryiii merged commit 7f2214b into pybind:master Mar 28, 2024
84 checks passed
@henryiii henryiii deleted the henryiii/chore/bumpcmake branch March 28, 2024 00:11
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Mar 28, 2024
@henryiii
Copy link
Collaborator Author

Yep, v5 seems to be the problem. The configuration file (path: .github/labeler_merged.yml) isn't not found locally, fetching via the api - Isn't not? But it seems to be showing up with both v4 and v5, so I guess that's not it.

tttapa pushed a commit to tttapa/pybind11 that referenced this pull request Apr 1, 2024
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants