Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nicer stack level for warning #4516

Merged
merged 1 commit into from
Feb 17, 2023
Merged

fix: nicer stack level for warning #4516

merged 1 commit into from
Feb 17, 2023

Conversation

henryiii
Copy link
Collaborator

Quick followup to #4513.

@henryiii
fix: nicer stack level for warning
821d4dc 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
rwgk
rwgk approved these changes Feb 17, 2023
View reviewed changes
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@henryiii henryiii merged commit 68211d4 into pybind:master Feb 17, 2023
@henryiii henryiii deleted the henryiii/fix/stacklevel branch February 17, 2023 22:13
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Feb 17, 2023
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Feb 24, 2023
henryiii added a commit that referenced this pull request Feb 24, 2023
@henryiii
fix: nicer stack level for warning (#4516)
f5cff4f 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwgk rwgk rwgk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henryiii @rwgk