Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make warning suppressions MINGW-specific again. #4515

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Feb 17, 2023

Description

Background: #4285 (comment)

For completeness, this is why I happened to notice: 7926130

Suggested changelog entry:

@rwgk rwgk marked this pull request as ready for review February 17, 2023 20:33
Copy link
Collaborator

@EthanSteinberg EthanSteinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rwgk
Copy link
Collaborator Author

rwgk commented Feb 17, 2023

Thanks Ethan!

@rwgk rwgk merged commit 6a5e600 into pybind:master Feb 17, 2023
@rwgk rwgk deleted the eigen_mingw_specific_warning_disable branch February 17, 2023 20:58
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Feb 17, 2023
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Feb 17, 2023
henryiii pushed a commit that referenced this pull request Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants