Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo accidental one-line change under PR #3913 #4060

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Undo accidental one-line change under PR #3913 #4060

merged 1 commit into from
Jul 12, 2022

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Jul 12, 2022 •
edited by henryiii
Loading

Description

Apparently this line was changed accidentally in the global change from NDEBUG → PYBIND11_DETAILED_ERROR_MESSAGES.

I only noticed now, by chance, in passing.

Undo accidental one-line change under PR #3913

@rwgk rwgk requested review from henryiii and Skylion007 July 12, 2022 17:45
@rwgk
Copy link
Collaborator Author

rwgk commented Jul 12, 2022

Thanks Aaron!

@rwgk rwgk merged commit 023b3f3 into pybind:master Jul 12, 2022
@rwgk rwgk deleted the fix_minor_NDEBUG_accident branch July 12, 2022 19:02
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Jul 12, 2022
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Jul 15, 2022
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@henryiii henryiii Awaiting requested review from henryiii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rwgk @Skylion007 @henryiii