Fix file extension on windows with cp36 and cp37 #3919
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed that with #3764 pybind11 modules now have
.pyd
as file extension on Windows for CPython 3.6 and CPython 3.7 while it previously was.cp36-win_amd64.pyd
and.cp37-win_amd64.pyd
, respectively. That was probably just an oversight, which should be fixed with this PR.PS: Tried to be consistent with the usage of
;
but I don't know why it's used here in the first place.Suggested changelog entry: