Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Make stl_bind take slice as const_ref #3852

Merged
merged 3 commits into from
Apr 11, 2022
Merged

chore: Make stl_bind take slice as const_ref #3852

merged 3 commits into from
Apr 11, 2022

Conversation

Skylion007
Copy link
Collaborator

Description

  • I noticed that the slice arg was being copied in stl-bind when we really only need to take it by const-ref within the lambdas. This should remove some unnecessary copies and their corresponding reference counts.

Suggested changelog entry:

* stil_bind.h bindings now take slice args as a const-ref.

@Skylion007 Skylion007 merged commit 1b27b74 into pybind:master Apr 11, 2022
@Skylion007 Skylion007 deleted the skylion007-stlbind-constref-slice branch April 11, 2022 17:53
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Apr 11, 2022
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Jul 9, 2022
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwgk rwgk rwgk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Skylion007 @rwgk @henryiii