Skip to content

Conversation

@Skylion007
Copy link
Collaborator

Description

  • The recent clang-tidy fixes did not have full coverage because of various ifdefs. I ran clang-tidy on my local machine and found lots of errors. Adding the fixes in this PR. We may want to use cmake to run clang-tidy on every CI to catch this or at least have the clang-tidy config use the debug config.

@Skylion007 Skylion007 requested review from henryiii and rwgk February 10, 2022 16:30
@rwgk
Copy link
Collaborator

rwgk commented Feb 10, 2022

Awesome, thanks for catching this! I'll merge this now to get this into #3712 & #3713.

For later: clang-tidy is very slow unfortunately, running in every CI could be a drag. Maybe 4 total: (clang, gcc) x (NDEBUG yes/no)?

@rwgk rwgk merged commit dc9803c into pybind:master Feb 10, 2022
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Feb 10, 2022
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants