Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(clang-tidy): Add missing clang-tidy fixes #3715

Merged
merged 1 commit into from
Feb 10, 2022
Merged

chore(clang-tidy): Add missing clang-tidy fixes #3715

merged 1 commit into from
Feb 10, 2022

Conversation

Skylion007
Copy link
Collaborator

Description

  • The recent clang-tidy fixes did not have full coverage because of various ifdefs. I ran clang-tidy on my local machine and found lots of errors. Adding the fixes in this PR. We may want to use cmake to run clang-tidy on every CI to catch this or at least have the clang-tidy config use the debug config.

@rwgk
Copy link
Collaborator

rwgk commented Feb 10, 2022

Awesome, thanks for catching this! I'll merge this now to get this into #3712 & #3713.

For later: clang-tidy is very slow unfortunately, running in every CI could be a drag. Maybe 4 total: (clang, gcc) x (NDEBUG yes/no)?

@rwgk rwgk merged commit dc9803c into pybind:master Feb 10, 2022
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Feb 10, 2022
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Feb 10, 2022
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwgk rwgk Awaiting requested review from rwgk

@henryiii henryiii Awaiting requested review from henryiii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Skylion007 @rwgk