Manually applying two clang-format changes that need fix-ups for clang-tidy. #3705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Oops, sorry I forgot to mark this as read for review before. |
Collaborator
Author
|
This is such a tiny whitespace thing, I'll merge it now, so that I have a clean baseline for working on the comments, following the plan under #3703 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Preparation for full
clang-formating, informed by work under PRs #3683 and #3703.With these manual "forward ports" of clang-format changes + manual fix-ups for clang-tidy compatibility, a full clang-format run builds out of the box.
Suggested changelog entry: