Fix py::kw_only when used before the first arg of a method #3488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implicit space for the `self` argument isn't added until we hit the first argument, but this wasn't being done for kw_only or pos_only, and so a kw_only before the first argument would break. This fixes it by properly checking whether we need to add the self arg. (The pos_only issue here was extremely mild -- you didn't get the `/` in the docstring, but AFAICT it has no other effect since there are no meaningful arguments before it anyway).
rwgk
approved these changes
Nov 20, 2021
|
For the record: I ran the clang sanitizers (asan, msan, tsan, ubsan) with this PR included. All fine. (There are only a handful of known long-standing failures.) I also initiated Google global testing (includes testing many OSS packages). Results in ~7 hours. But I think it's safe to merge this PR asap. |
- rename check_have_self_arg -> append_self_arg_if_needed - move the argument name inline comments before the args instead of after
|
Thanks Jason! — In the meantime the Google-global testing finished without issues. I'll go ahead with merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implicit space for the
selfargument isn't added until we hit the first argument, but this wasn't being done forkw_onlyorpos_onlythat happen before the first argument, and so akw_onlybefore the first argument on methods/constructors would break.This fixes it by properly checking whether we need to add the self arg in those places as well.
(The
pos_onlyissue here was extremely mild -- you didn't get the/in the docstring, but AFAICT it has no other effect since there are no meaningful arguments before it anyway).Closes #3789 (thanks to @rwgk for the minimal test case in that PR).