Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract gil management functions to separate header #2845

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Extract gil management functions to separate header #2845

merged 1 commit into from
Feb 23, 2021

Conversation

virtuald
Copy link
Contributor

@virtuald virtuald commented Feb 3, 2021

Description

Move gil_scoped_* to gil.h so that it can be used from cast.h, required for #2839

Suggested changelog entry:

N/A

@virtuald virtuald force-pushed the mv-gil branch 3 times, most recently from d3adbe1 to 918c909 Compare February 3, 2021 04:32
henryiii
henryiii approved these changes Feb 5, 2021
View reviewed changes
Copy link
Collaborator

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally in favor of more, smaller files with better separation. Makes it easier to refactor, find what you are looking for, include just the right part, etc.

@virtuald virtuald mentioned this pull request Feb 23, 2021
Open
@rwgk
Copy link
Collaborator

rwgk commented Feb 23, 2021

CI all green! I'll merge this now. Thanks @henryiii for your approval!

@rwgk rwgk merged commit c0fbb02 into pybind:master Feb 23, 2021
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Feb 23, 2021
@virtuald virtuald deleted the mv-gil branch February 23, 2021 03:25
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Jul 12, 2021
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryiii henryiii henryiii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@virtuald @rwgk @henryiii