Skip to content

tests: Fix test override execution #2512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

EricCousineau-TRI
Copy link
Collaborator

Hotfix for #2353

Ran into this when trying to add a quick test on upstream.

@EricCousineau-TRI
Copy link
Collaborator Author

EricCousineau-TRI commented Sep 19, 2020

Er, from looking closer, seems like current master should work. Perhaps I did something wrong. Will try a few more times.

@EricCousineau-TRI
Copy link
Collaborator Author

EricCousineau-TRI commented Sep 19, 2020

K, updated (via force push).

Two things:

  • The replacement output to PYBIND11_BINARY_TEST_FILES, but then code below consumed PYBIND11_BINARY_PYTEST_FILES (missing PY)
  • The replacement basically tells pytest to read the Python files from the binary dir, but it should've been the src dir.

Copy link
Collaborator

@bstaletic bstaletic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess @henryiii should have the final word, but this makes sense.

@henryiii
Copy link
Collaborator

Looks good to me! Thanks!

@henryiii henryiii merged commit d74be32 into pybind:master Sep 22, 2020
@EricCousineau-TRI
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants