ci: cmake Configure test #2327
Merged
ci: cmake Configure test #2327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This only adds a few tests, no other changes, and my next PR requires it, so I think it's safe to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few basic config checks to make sure we support what we say we do. Not building, just config. (note: the 2.8 build actually doesn't run the tests properly If you do have it run, the cpp tests "pass" in 0 seconds. We will drop the 2.8 test when we drop 2.8 support (very soon)).
We may split this test later into a "build test suite" and a "use as sub package / config" test (based on the current tests in the test suite so we can have a higher requirement for the test suite than for user code. This should let us simplify the test cmake code we have to maintain, and help us support nicer optional features (since we can then use them ourselves).