Skip to content

Commit 8b47bee

Browse files
committed
Drop 2019 or update to 2022/latest
1 parent 2c5a631 commit 8b47bee

File tree

2 files changed

+10
-19
lines changed

2 files changed

+10
-19
lines changed

.github/workflows/ci.yml

Lines changed: 10 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ jobs:
118118
- runs-on: macos-latest
119119
python-version: 'graalpy-24.2'
120120

121-
- runs-on: windows-2019
121+
- runs-on: windows-latest
122122
python-version: '3.9'
123123
cmake-args: -DPYBIND11_TEST_SMART_HOLDER=ON
124124
- runs-on: windows-2022
@@ -819,20 +819,16 @@ jobs:
819819
strategy:
820820
fail-fast: false
821821
matrix:
822-
python:
823-
- '3.8'
824-
- '3.10'
825-
- '3.13'
826-
827822
include:
828-
- python: '3.10'
829-
args: -DCMAKE_CXX_STANDARD=20
830823
- python: '3.8'
831824
args: -DCMAKE_CXX_STANDARD=17
825+
- python: '3.10'
826+
args: -DCMAKE_CXX_STANDARD=20
827+
- python: '3.13'
832828

833829

834-
name: "🐍 ${{ matrix.python }} • MSVC 2019 • x86 ${{ matrix.args }}"
835-
runs-on: windows-2019
830+
name: "🐍 ${{ matrix.python }} • MSVC 2022 • x86 ${{ matrix.args }}"
831+
runs-on: windows-2022
836832

837833
steps:
838834
- uses: actions/checkout@v4
@@ -855,11 +851,10 @@ jobs:
855851
run: |
856852
python -m pip install -r tests/requirements.txt
857853
858-
# First build - C++11 mode and inplace
859854
- name: Configure ${{ matrix.args }}
860855
run: >
861856
cmake -S . -B build
862-
-G "Visual Studio 16 2019" -A Win32
857+
-G "Visual Studio 17 2022" -A Win32
863858
-DPYBIND11_WERROR=ON
864859
-DDOWNLOAD_CATCH=ON
865860
-DDOWNLOAD_EIGEN=ON
@@ -881,8 +876,8 @@ jobs:
881876
- python: 3.8
882877
args: -DCMAKE_CXX_STANDARD=17
883878

884-
name: "🐍 ${{ matrix.python }} • MSVC 2019 (Debug) • x86 ${{ matrix.args }}"
885-
runs-on: windows-2019
879+
name: "🐍 ${{ matrix.python }} • MSVC 2022 (Debug) • x86 ${{ matrix.args }}"
880+
runs-on: windows-2022
886881

887882
steps:
888883
- uses: actions/checkout@v4
@@ -905,11 +900,10 @@ jobs:
905900
run: |
906901
python -m pip install -r tests/requirements.txt
907902
908-
# First build - C++11 mode and inplace
909903
- name: Configure ${{ matrix.args }}
910904
run: >
911905
cmake -S . -B build
912-
-G "Visual Studio 16 2019" -A Win32
906+
-G "Visual Studio 17 2022" -A Win32
913907
-DCMAKE_BUILD_TYPE=Debug
914908
-DPYBIND11_WERROR=ON
915909
-DDOWNLOAD_CATCH=ON

.github/workflows/configure.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,6 @@ jobs:
4141
- runs-on: macos-14
4242
cmake: "4.0"
4343

44-
- runs-on: windows-latest
45-
cmake: "3.18"
46-
4744
- runs-on: windows-latest
4845
cmake: "4.0"
4946

0 commit comments

Comments
 (0)