Add back PYBIND11_HAS_INTERNALS_WITH_SMART_HOLDER_SUPPORT

rwgk · rwgk · commit 4b0564337653 · 2025-03-01T09:51:41.000-08:00
This define was * introduced with #5286 * removed with #5531 It is has been in use here: * https://github.com/pybind/pybind11_protobuf/blob/f02a2b7653bc50eb5119d125842a3870db95d251/pybind11_protobuf/native_proto_caster.h#L89-L101 Currently pybind11 unit tests for the two holder caster backwards compatibility traits * `copyable_holder_caster_shared_ptr_with_smart_holder_support_enabled` * `move_only_holder_caster_unique_ptr_with_smart_holder_support_enabled` are missing.
diff --git a/include/pybind11/detail/internals.h b/include/pybind11/detail/internals.h
@@ -211,6 +211,9 @@ struct internals {
     }
 };
 
+// For backwards compatibility (i.e. #ifdef guards):
+#define PYBIND11_HAS_INTERNALS_WITH_SMART_HOLDER_SUPPORT
+
 enum class holder_enum_t : uint8_t {
     undefined,
     std_unique_ptr, // Default, lacking interop with std::shared_ptr.

Original file line number	Diff line number	Diff line change
`@@ -211,6 +211,9 @@ struct internals {`
`211`	`211`	`}`
`212`	`212`	`};`
`213`	`213`
	`214`	`+// For backwards compatibility (i.e. #ifdef guards):`
	`215`	`+#define PYBIND11_HAS_INTERNALS_WITH_SMART_HOLDER_SUPPORT`
	`216`	`+`
`214`	`217`	`enum class holder_enum_t : uint8_t {`
`215`	`218`	`undefined,`
`216`	`219`	`std_unique_ptr, // Default, lacking interop with std::shared_ptr.`