Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print missing filename #427

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Print missing filename #427

merged 2 commits into from
Aug 21, 2024

Conversation

dnerini
Copy link
Member

@dnerini dnerini commented Aug 21, 2024

when looking into #426, I noticed that the the pysteps.io.archive.find_by_date function wrongly logs None instead of the wrong filename. This PR fixes it.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 83.85%. Comparing base (e3eed9e) to head (77b4c1e).
Report is 1 commits behind head on master.

Files Patch % Lines
pysteps/io/archive.py 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #427      +/-   ##
==========================================
- Coverage   83.86%   83.85%   -0.01%     
==========================================
  Files         160      160              
  Lines       12781    12780       -1     
==========================================
- Hits        10719    10717       -2     
- Misses       2062     2063       +1     
Flag Coverage Δ
unit_tests 83.85% <16.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dnerini dnerini merged commit b4b41a5 into master Aug 21, 2024
8 of 10 checks passed
@dnerini dnerini deleted the print-fn-not-found branch August 21, 2024 21:40
@dnerini dnerini changed the title Print the wrong filename when not found Print missing filename Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant