Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ascending #302

Merged
merged 4 commits into from
Apr 27, 2024
Merged

Test ascending #302

merged 4 commits into from
Apr 27, 2024

Conversation

pierrejavelle
Copy link
Contributor

new test for ascending values

Copy link
Contributor

@feldmann-m feldmann-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test looks reasonable to me, however I cannot test it at the moment.

@aperezhortal
Copy link
Member

Thanks @pierrejavelle for submitting the PR! I left a few review comments that would be great to tackle before merging.
(Note that PR #300 is also open addressing the same issue.)

@dnerini dnerini merged commit 38cc191 into pySTEPS:master Apr 27, 2024
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants