Updated editors guide #322
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers should be added to the initial response
lwasser
reviewed
Jun 17, 2025
| @@ -120,7 +120,7 @@ All reviews happen in GitHub issues. The template for the | |||
| `yaml` header of a review submission below will be | |||
| referenced multiple times in the steps below: | |||
|
|
|||
| ```{include} ../appendices/issue-review-template.md | |||
| ```{include} | |||
There was a problem hiding this comment.
Hey @crhea93, I'm curious about what removing these resources includes? They should render the content on the page for the user to copy. Was this intentional?
There was a problem hiding this comment.
Weirdly, it's rendering in CI, but I don't understand how because the path to the include is removed? 🙃 i will come back to this later unless I am just missing some magic!
There was a problem hiding this comment.
Ah no it should not be removed!! Let me look into why it is doing this....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated editors guide to hopefully make it more clear when the reviewers should be added to the initial response.