Fixing Table of Contents/ Nav #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwasser
approved these changes
May 30, 2024
There was a problem hiding this comment.
@BSuperbad thank you for this contribution! once CI runs i'll get it merged! it was great meeting you at pyconus this year!
|
@all-contributors please add @BSuperbad for code, review |
|
I've put up a pull request to add @BSuperbad! 🎉 |
|
this addresses #264 @BSuperbad THANK YOU for this submission! one small tip - when you open an pr - at the top you can reference the issue that you opened like this
this will magically then close the issue once the pr is merged!! best of luck to you in your program that you're working on! it was fun to meet you at pycon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was slightly confusing to have 'Migrate setup.py to a pyproject.toml' (for existing packages) in the getting started/ tutorial setup portion of the table of contents/ nav. Proposing to move it down under a new heading 'Hatch for Existing Packages'
Thank you!