Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get-to-know-hatch.md for consistent style of "Hatch" etc. #227

Merged
merged 3 commits into from
May 6, 2024

Conversation

ptressel
Copy link
Contributor

@ptressel ptressel commented Apr 8, 2024

Use "Hatch" to refer to the tool, "hatch" to the command. Use fixed-pitch text for commands and file names. Add missing periods. Note there is one sentence re. comparing Hatch to other tools, where their names are all lowercase, but I don't know if the other tools are commonly referred to that way.

Use "Hatch" to refer to the tool, "hatch" to the command.  Use fixed-pitch text for commands and file names.  Add missing periods.  Note there is one sentence re. comparing Hatch to other tools, where their names are all lowercase, but I don't know if the other tools are commonly referred to that way.
Copy link
Member

@lwasser lwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me as well!! thanks @ptressel there was a merge conflict and i thijnk i resolved it in a way that aligned with your intent. but feel free to have a look in case i didn't. i'm approving this for merge however as well! i think it's ready to go!

@lwasser
Copy link
Member

lwasser commented Apr 15, 2024

hello there @ptressel - it also looks like we have a bad link in ci - if you see here - https://github.com/pyOpenSci/python-package-guide/actions/runs/8694415211/job/23843264627?pr=227#step:12:26

@ptressel
Copy link
Contributor Author

Ok, thanks for catching those @lwasser ! I'll come back after the end of Tax Day to have a look. :D

@lwasser
Copy link
Member

lwasser commented Apr 17, 2024

@ptressel ahhh tax day 😆 i know that feeling!! no rush on this at all!! ✨

@lwasser
Copy link
Member

lwasser commented May 6, 2024

ok! this is looking good. I am going to merge it and we can alway fix more things if we need to in the future! thank you again @ptressel !!

Copy link
Member

@lwasser lwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved!

@lwasser lwasser merged commit 2c16c62 into pyOpenSci:main May 6, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants