Filename issue in formatWarning method in utils.py #641
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created a pull request to address the
IndexError
which arises whenformatWarning()
in utils.py is passed afilename
string that doesn't contain a/
or\\
character. I simply implemented @CrimsonZen's suggestion of replacing:file = filename.replace("/","\\").rsplit("\\",1)[1] # find the file name
with
file = filename.replace("/","\\").rsplit("\\",1).pop() # find the file name
Hopefully this can be merged into the main branch at some point. This error arises because PyPDF2 overwrites
warnings.formatwarning
(issue #67). However, this pull request does not address the issue directly.