use zlib.decompressobj() do decode streams
#609
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should resolve py-pdf#88
|
I see that #603 does basically the same thing, but first tries to decode in the existing way and falls back to this approach and feeding data one byte at a time if the normal decompression fails. |
MartinThoma
added
the
Tiny
|
Do you think your PR or the other one should be merged? |
MartinThoma
added
the
needs-discussion
|
Thank you for your PR - I've now merged the other one as that one is guaranteed not to break any existing code. I will make a release on PyPI this month. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #88, as described in my comment there.