ENH: Add support for IndirectObject.__contains__
#3155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3155 +/- ##
==========================================
+ Coverage 96.51% 96.53% +0.01%
==========================================
Files 53 53
Lines 8875 8918 +43
Branches 1622 1635 +13
==========================================
+ Hits 8566 8609 +43
Misses 185 185
Partials 124 124 ☔ View full report in Codecov by Sentry. |
|
Thanks for the PR. I do not really think that this is a bug, but rather a new feature. Additionally, could you please provide a positive test as well? |
|
Sure, I added a positive test. BTW, some javascript tests already test for |
stefan6419846
changed the title
IndirectObject.__contains__
stefan6419846
added a commit
that referenced
this pull request
Mar 16, 2025
## What's new ### New Features (ENH) - Add support for `IndirectObject.__contains__` (#3155) by @noamkush ### Bug Fixes (BUG) - Fix detection of inline images followed by names or numbers (#3173) by @stefan6419846 ### Robustness (ROB) - Consider root objects without catalog type as fallback (#3175) by @stefan6419846 - Raise proper error on infinite loop when reading objects (#3169) by @stefan6419846 ### Documentation (DOC) - Mention memory consumption of text extraction (#3168) by @stefan6419846 ### Developer Experience (DEV) - Upgrade to ruff 0.10.0 (#3191) by @stefan6419846 [Full Changelog](5.3.1...5.4.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #3154