Skip to content

BUG: Fix object count for incremental writer #3117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

m32
Copy link
Contributor

@m32 m32 commented Feb 10, 2025

No description provided.

@m32 m32 changed the title #3116 fix and test for incremental writer - sizeof of read objects BUG: #3116 fix and test for incremental writer - sizeof of read objects Feb 10, 2025
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.51%. Comparing base (0347291) to head (030f239).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3117   +/-   ##
=======================================
  Coverage   96.51%   96.51%           
=======================================
  Files          53       53           
  Lines        8873     8873           
  Branches     1622     1622           
=======================================
  Hits         8564     8564           
  Misses        185      185           
  Partials      124      124           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefan6419846
Copy link
Collaborator

Thanks. Could you please have a look at the typing issue as well?

@m32
Copy link
Contributor Author

m32 commented Feb 11, 2025

fixed

Copy link
Collaborator

@stefan6419846 stefan6419846 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@stefan6419846 stefan6419846 changed the title BUG: #3116 fix and test for incremental writer - sizeof of read objects BUG: Fix object count for incremental writer Feb 11, 2025
@stefan6419846 stefan6419846 merged commit 2263dcb into py-pdf:main Feb 11, 2025
17 checks passed
stefan6419846 added a commit that referenced this pull request Mar 2, 2025
## What's new

### Bug Fixes (BUG)
- Use the correct name StandardEncoding for the predefined cmap (#3156) by @stefan6419846
- Handle inline images containing `EI ` sequences (#3152) by @stefan6419846
- Fix check box value which should be name object (#3124) by @stefan6419846
- Fix stream position on inline image fallback extraction (#3120) by @stefan6419846
- Fix object count for incremental writer (#3117) by @m32

### Robustness (ROB)
- Avoid index errors on empty lines in xref table (#3162) by @stefan6419846
- Improve handling of LZW decoder table overflow (#3159) by @stefan6419846
- Ignore non-numbers for width when building font width map (#3158) by @stefan6419846
- Avoid negative seek values when reading partially broken files (#3157) by @stefan6419846

### Documentation (DOC)
- Fixed PageObject.images example usage for replacing image (#3149) by @jutoth

[Full Changelog](5.3.0...5.3.1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The list of cloned objects is too large while using PdfWriter with incremental=True
2 participants