Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Use google style docstrings #1534

Merged
merged 7 commits into from
Jan 7, 2023
Merged

DOC: Use google style docstrings #1534

merged 7 commits into from
Jan 7, 2023

Conversation

MartinThoma
Copy link
Member

The Google Docstring style is way more readable than ReST style docstrings.

Additionally, replace most instances of 'pragma: no-cover' by 'deprecated'

Tools used:

  • pyment
  • pydocstyle

@MartinThoma MartinThoma force-pushed the google-docs branch 2 times, most recently from 8d1bea4 to 2c1277c Compare January 6, 2023 12:20
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 91.83% // Head: 91.83% // No change to project coverage 👍

Coverage data is based on head (70747a6) compared to base (0ba45ea).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1534   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files          33       33           
  Lines        6073     6073           
  Branches     1193     1193           
=======================================
  Hits         5577     5577           
  Misses        321      321           
  Partials      175      175           
Impacted Files Coverage Δ
pypdf/_encryption.py 92.18% <ø> (ø)
pypdf/_merger.py 93.18% <ø> (ø)
pypdf/_page.py 89.56% <ø> (ø)
pypdf/_protocols.py 80.00% <ø> (ø)
pypdf/_reader.py 90.36% <ø> (ø)
pypdf/_security.py 100.00% <ø> (ø)
pypdf/_utils.py 97.46% <ø> (ø)
pypdf/_writer.py 83.75% <ø> (ø)
pypdf/constants.py 100.00% <ø> (ø)
pypdf/filters.py 97.31% <ø> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MartinThoma MartinThoma force-pushed the google-docs branch 4 times, most recently from 16a506d to b738fe5 Compare January 6, 2023 13:17
The Google Docstring style is way more readable than ReST style docstrings.

Additionally, replace most instances of 'pragma: no-cover' by
'deprecated'.

Tools used:
- pyment
- pydocstyle
@MartinThoma MartinThoma merged commit 5c0b11d into main Jan 7, 2023
@MartinThoma MartinThoma deleted the google-docs branch January 7, 2023 18:03
MartinThoma added a commit that referenced this pull request Jan 8, 2023
New Features (ENH):
-  Accept hierarchical fields (#1529)

Documentation (DOC):
-  Use google style docstrings (#1534)
-  Fix linked markdown documents (#1537)

Developer Experience (DEV):
-  Update docs config (#1535)

[Full Changelog](3.2.0...3.2.1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant