-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Accept hierarchical fields #1529
Conversation
Codecov ReportBase: 91.83% // Head: 91.79% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1529 +/- ##
==========================================
- Coverage 91.83% 91.79% -0.04%
==========================================
Files 33 33
Lines 6073 6093 +20
Branches 1193 1200 +7
==========================================
+ Hits 5577 5593 +16
- Misses 321 323 +2
- Partials 175 177 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
indexed names implemented with . not _ (possible mix up with names
@MartinThoma |
Overall, the PR looks good to me :-) I will have another look tomorrow, but if it's only those minor stylistic things, I can also fix them after merging :-) Good work @pubpub-zz 👍 🙏 |
Co-authored-by: Martin Thoma <info@martin-thoma.de>
New Features (ENH): - Accept hierarchical fields (#1529) Documentation (DOC): - Use google style docstrings (#1534) - Fix linked markdown documents (#1537) Developer Experience (DEV): - Update docs config (#1535) [Full Changelog](3.2.0...3.2.1)
fixes #1468
Add an optional parameter to
get_form_text_fields
TBC : behavior with multiple fields with same name create sequence _2, _3, ... does not seem to be applied
Pending : Test to be added