Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STY: Re-use code via get_outlines_property in tests #1130

Merged
merged 1 commit into from
Jul 18, 2022
Merged

STY: Re-use code via get_outlines_property in tests #1130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 15 additions & 27 deletions tests/test_reader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -876,23 +876,23 @@ def test_outline_font_format():
assert reader.outlines[0].font_format == 2


def get_outlines_property(outlines, attribute_name: str):
results = []
if isinstance(outlines, list):
for outline in outlines:
if isinstance(outline, Destination):
results.append(getattr(outline, attribute_name))
else:
results.append(get_outlines_property(outline, attribute_name))
else:
raise ValueError(f"got {type(outlines)}")
return results


def test_outline_title_issue_1121():
reader = PdfReader(EXTERNAL_ROOT / "014-outlines/mistitled_outlines_example.pdf")

def get_titles_only(outlines, results=None):
if results is None:
results = []
if isinstance(outlines, list):
for outline in outlines:
if isinstance(outline, Destination):
results.append(outline.title)
else:
results.append(get_titles_only(outline))
else:
raise ValueError(f"got {type(outlines)}")
return results

assert get_titles_only(reader.outlines) == [
assert get_outlines_property(reader.outlines, "title") == [
"First",
[
"Second",
Expand Down Expand Up @@ -938,19 +938,7 @@ def get_titles_only(outlines, results=None):
def test_outline_count():
reader = PdfReader(EXTERNAL_ROOT / "014-outlines/mistitled_outlines_example.pdf")

def get_counts_only(outlines, results=None):
if results is None:
results = []
if isinstance(outlines, list):
for outline in outlines:
if isinstance(outline, Destination):
results.append(outline.outline_count)
else:
results.append(get_counts_only(outline))
else:
raise ValueError(f"got {type(outlines)}")
return results
assert get_counts_only(reader.outlines) == [
assert get_outlines_property(reader.outlines, "outline_count") == [
5,
[
None,
Expand Down