diff --git a/PyPDF2/_writer.py b/PyPDF2/_writer.py index a56d4a8fb..a8ee9232d 100644 --- a/PyPDF2/_writer.py +++ b/PyPDF2/_writer.py @@ -1259,7 +1259,7 @@ def add_bookmark( italic: bool = False, fit: FitType = "/Fit", *args: ZoomArgType, - ) -> IndirectObject: + ) -> IndirectObject: # pragma: no cover """ .. deprecated:: 2.9.0 diff --git a/tests/test_generic.py b/tests/test_generic.py index 13a0c6b6c..6a82df22c 100644 --- a/tests/test_generic.py +++ b/tests/test_generic.py @@ -608,6 +608,18 @@ def test_issue_997(mock_logger_warning): "Overwriting cache for 0 4", "PyPDF2._reader" ) + # Strict + merger = PdfMerger(strict=True) + merged_filename = "tmp-out.pdf" + with pytest.raises(PdfReadError) as exc: + merger.append( + BytesIO(get_pdf_from_url(url, name=name)) + ) # here the error raises + assert exc.value.args[0] == "Could not find object." + with open(merged_filename, "wb") as f: + merger.write(f) + merger.close() + # cleanup os.remove(merged_filename) diff --git a/tests/test_writer.py b/tests/test_writer.py index d90c8bd45..0b7fa8b89 100644 --- a/tests/test_writer.py +++ b/tests/test_writer.py @@ -91,8 +91,9 @@ def writer_operate(writer): with pytest.warns(PendingDeprecationWarning): writer.add_link(2, 1, RectangleObject([0, 0, 100, 100])) assert writer._get_page_layout() is None - writer._set_page_layout("broken") - writer._set_page_layout("/SinglePage") + writer.page_layout = "broken" + assert writer.page_layout == "broken" + writer.page_layout = NameObject("/SinglePage") assert writer._get_page_layout() == "/SinglePage" assert writer._get_page_mode() is None writer.set_page_mode("/UseNone")