Use Ubuntu 22.04 LTS

[ejsc1]

[pfps]

I'm not sure where this comes from. Please expand.

[ejsc1]

[pfps]

That's GitHub running the pre-commit. Is there any way to change the OS there?

[ejsc1]

Hello,

It seems that here is this:
https://github.com/pwr-Solaar/Solaar/blob/master/.github/workflows/checks.yml

More information:
actions/runner-images#5490

Thanks @pfps

[ejsc1]

After the change:

Then the new problems

[pfps]

Even though 22.04 is available it is probably better to stay with latest - as that is likely the default setup.

I've been seeing the error you are seeing on my fork of Solaar. I'm not sure what is causing that. There is lots of chatter about similar problems but I haven't seen anything that looks relevant.

[ejsc1]

I found a project that uses ubuntu-22.04:
https://github.com/flatpak/flatpak/blob/main/.github/workflows/check.yml#L41

[ejsc1]

It seems to be a pre-commit issue, not a Python issue.

Run pre-commit/action@v2.0.0
  with:
    extra_args: --all-files
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.11.0/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.11.0/x64/lib
install pre-commit
  /opt/hostedtoolcache/Python/3.11.0/x64/bin/pip install pre-commit
  Collecting pre-commit
    Downloading pre_commit-[2](https://github.com/ejsc1/Solaar/actions/runs/3508340631/jobs/5876680526#step:4:2).20.0-py2.py[3](https://github.com/ejsc1/Solaar/actions/runs/3508340631/jobs/5876680526#step:4:3)-none-any.whl (199 kB)
       ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 199.5/199.5 kB 5.2 MB/s eta 0:00:00
  Collecting cfgv>=2.0.0
    Downloading cfgv-3.3.1-py2.py3-none-any.whl (7.3 kB)
  Collecting identify>=1.0.0
    Downloading identify-2.5.9-py2.py3-none-any.whl (98 kB)
       ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 98.8/98.8 kB 9.0 MB/s eta 0:00:00
  Collecting nodeenv>=0.11.1
    Downloading nodeenv-1.7.0-py2.py3-none-any.whl (21 kB)
  Collecting pyyaml>=5.1
    Downloading PyYAML-6.0-cp311-cp311-manylinux_2_17_x86_6[4](https://github.com/ejsc1/Solaar/actions/runs/3508340631/jobs/5876680526#step:4:4).manylinux2014_x86_64.whl (7[5](https://github.com/ejsc1/Solaar/actions/runs/3508340631/jobs/5876680526#step:4:5)7 kB)
       ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 757.9/757.9 kB 13.5 MB/s eta 0:00:00
  Collecting toml
    Downloading toml-0.10.2-py2.py3-none-any.whl (1[6](https://github.com/ejsc1/Solaar/actions/runs/3508340631/jobs/5876680526#step:4:6) kB)
  Collecting virtualenv>=20.0.8
    Downloading virtualenv-20.16.[7](https://github.com/ejsc1/Solaar/actions/runs/3508340631/jobs/5876680526#step:4:8)-py3-none-any.whl ([8](https://github.com/ejsc1/Solaar/actions/runs/3508340631/jobs/5876680526#step:4:9).8 MB)
       ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 8.8/8.8 MB 38.3 MB/s eta 0:00:00
  Requirement already satisfied: setuptools in /opt/hostedtoolcache/Python/3.11.0/x64/lib/python3.11/site-packages (from nodeenv>=0.11.1->pre-commit) (65.5.0)
  Collecting distlib<1,>=0.3.6
    Downloading distlib-0.3.6-py2.py3-none-any.whl (468 kB)
       ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 468.5/468.5 kB 87.8 MB/s eta 0:00:00
  Collecting filelock<4,>=3.4.1
    Downloading filelock-3.8.0-py3-none-any.whl (10 kB)
  Collecting platformdirs<3,>=2.4
    Downloading platformdirs-2.5.4-py3-none-any.whl (14 kB)
  Installing collected packages: distlib, toml, pyyaml, platformdirs, nodeenv, identify, filelock, cfgv, virtualenv, pre-commit
  Successfully installed cfgv-3.3.1 distlib-0.3.6 filelock-3.8.0 identify-2.5.[9](https://github.com/ejsc1/Solaar/actions/runs/3508340631/jobs/5876680526#step:4:10) nodeenv-1.7.0 platformdirs-2.5.4 pre-commit-2.20.0 pyyaml-6.0 toml-0.[10](https://github.com/ejsc1/Solaar/actions/runs/3508340631/jobs/5876680526#step:4:11).2 virtualenv-20.16.7
  
  Notice:  A new release of pip available: 22.3 -> 22.3.1
  Notice:  To update, run: pip install --upgrade pip
  /opt/hostedtoolcache/Python/3.[11](https://github.com/ejsc1/Solaar/actions/runs/3508340631/jobs/5876680526#step:4:12).0/x64/bin/pip freeze --local
  cfgv==3.3.1
  distlib==0.3.6
  filelock==3.8.0
  identify==2.5.9
  nodeenv==1.7.0
  platformdirs==2.5.4
  pre-commit==2.20.0
  PyYAML==6.0
  toml==0.10.2
  virtualenv==20.16.7
/opt/hostedtoolcache/Python/3.11.0/x64/bin/pre-commit run --show-diff-on-failure --color=always --all-files
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/pre-commit/mirrors-yapf.
[INFO] Initializing environment for https://github.com/pre-commit/mirrors-isort.
[INFO] Initializing environment for https://gitlab.com/pycqa/flake8.
An unexpected error has occurred: CalledProcessError: command: ('/usr/bin/git', 'fetch', 'origin', '--tags')
return code: [12](https://github.com/ejsc1/Solaar/actions/runs/3508340631/jobs/5876680526#step:4:13)8
expected return code: 0
stdout: (none)
stderr:
    fatal: could not read Username for 'https://gitlab.com/': No such device or address
    
Check the log at /home/runner/.cache/pre-commit/pre-commit.log
Error: The process '/opt/hostedtoolcache/Python/3.11.0/x[64](https://github.com/ejsc1/Solaar/actions/runs/3508340631/jobs/5876680526#step:4:66)/bin/pre-commit' failed with exit code 3

[ejsc1]

After commenting:

The error does not appear:

[ejsc1]

This URL does not exist:
https://gitlab.com/pycqa/flake8

This is the correct URL:
https://github.com/PyCQA/flake8

More information:
https://github.com/Farama-Foundation/Gymnasium/pull/131/files

[pfps]

Good catch. I wonder when this changed.

[pfps]

I'm still not seeing a reason to move from 'latest'.

[ejsc1]

I'm still not seeing a reason to move from 'latest'.

Applications are up to date actions/runner-images#5490

[ejsc1]

If it gets ugly, we go back to 20.04 :)

[pfps]

I'm still saying to not change until GitHub moves latest to 22.04, which should happen by the end of this year.

[ejsc1]

@pfps This PR is better #1869?

Thanks

[pfps]

Latest has switched to 22.04 or will very soon.