Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: pwaller/pyfiglet
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.1
Choose a base ref
...
head repository: pwaller/pyfiglet
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.0.2
Choose a head ref
  • 2 commits
  • 3 files changed
  • 2 contributors

Commits on Sep 13, 2023

  1. Close file handle in preloadFont (#131) 

    Commit 785f90a introduced a regression
by not using a context manager when opening the file, which eventually
lead to a resource leak because the file handle 'f' never gets closed.

This is fixed by passing the font path, instead of the open file handle,
and by opening the handle using a 'with' context manager.

The issue can be reproduced by running pytest with the '-W error' flag
for the following minimal example:

    def test_file_gets_closed():
        Figlet().renderText("")

This will succeed now, but fails for v1.0.1.
    @anz-ableton
    anz-ableton authored Sep 13, 2023
    Configuration menu
    Copy the full SHA
    7d1ae45 View commit details
    Browse the repository at this point in the history

  2. Bump to version 1.0.2

    @pwaller
    pwaller committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    be130d6 View commit details
    Browse the repository at this point in the history
Loading