Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pwa-update] Emit isEligible (or any event) #2668

Open
levizwannah opened this issue Mar 4, 2022 · 4 comments
Open

[pwa-update] Emit isEligible (or any event) #2668

levizwannah opened this issue Mar 4, 2022 · 4 comments

Comments

@levizwannah
Copy link

Tell us about your feature idea

To show our install buttons, we want to know if the client is eligible. So since Pwa-install has the isEligible property, can you emit an isEligible event if the client is eligible that we can listen for and show the install buttons?

Do you have an implementation or a solution in mind?

Just emit the isEligible event.

Have you considered any alternatives?

Yeah, but check client eligibility is not straight forward. And i couldn't check the pwa-install isEligible property because I don't know whose code gets executed first.

@ghost
Copy link

ghost commented Mar 4, 2022

Thanks for submitting a new feature request! I've automatically added a vote 👍 reaction to help get things started. Other community members can vote to help us prioritize this feature in the future.

@ghost ghost added the needs attention 👋 label Mar 19, 2022
@ghost
Copy link

ghost commented Mar 19, 2022

This issue has been marked as "needs attention 👋" due to no activity for 15 days. Please triage the issue so the fix can be established.

1 similar comment
@ghost
Copy link

ghost commented Apr 3, 2022

This issue has been marked as "needs attention 👋" due to no activity for 15 days. Please triage the issue so the fix can be established.

@nmetulev nmetulev changed the title Emit isEligible (or any event) [pwa-update] Emit isEligible (or any event) Apr 6, 2022
@nmetulev
Copy link
Member

nmetulev commented Apr 6, 2022

thank you for this suggestion @levizwannah. Let us know if this is something you'd like to contribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants